Analysis enhancement - better plural stemmer than minimal_english. #43248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>enhancement
:Search Relevance/Analysis
|
Pinging @elastic/es-search |
romseygeek
reviewed
Jun 26, 2019
|
|
||
| // *CHES - would be good to find a simple rule that solves lunches, churches but doesn't break aches | ||
| // documenting current behaviour here as a known issue: | ||
| assertAnalyzesTo(analyzer, "lunches", new String[]{"lunche"}); |
There was a problem hiding this comment.
Looking at http://www.thefreedictionary.com/words-that-end-in-ches I think that 'avalanche' and 'headache' are the odd ones out here - consider brooch/brooches, branch/branches, couch/couches. Maybe have a specific rule for -ache, and some exceptions?
Drops the trailing “e” in taxes, dresses, watches etc that otherwise cause mismatches with plural and singular forms Closes elastic#42892
Made ies->y stemming stricter so short words match eg ties==tie Removed special-case code for crazy-rare words iaes and eies
…nes-> oe e.g. shoes
|
What's the status of this PR @markharwood ? Is it still relevant ? |
|
Pinging @elastic/es-search (Team:Search) |
javanna
added
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops the trailing “e” in taxes, dresses, watches, dishes etc that otherwise cause mismatches with plural and singular forms.
See the issue for recall benchmarking results on typical data.
Closes #42892